Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uffizzi should not rebuild the Meilisearch image from scratch #3476

Closed
curquiza opened this issue Feb 9, 2023 · 2 comments · Fixed by #3482
Closed

Uffizzi should not rebuild the Meilisearch image from scratch #3476

curquiza opened this issue Feb 9, 2023 · 2 comments · Fixed by #3482
Assignees
@waveywaves
Labels
bug Something isn't working as expected tooling Not directly project related, like Docker, Homebrew...

Comments

@curquiza
Copy link
Member

curquiza commented Feb 9, 2023

As reported here #3454 (comment), Uffizzi should not re-build from scratch the Meilisearch image
In the PR, you can see the small change done between each commit, but the image build is still btw 28 and 23 minutes.

Discussed with @waveywaves who is working on it 😊
@curquiza curquiza added bug Something isn't working as expected tooling Not directly project related, like Docker, Homebrew... labels Feb 9, 2023
@curquiza curquiza mentioned this issue Feb 9, 2023
Closed
@waveywaves
Copy link
Contributor

@curquiza can you assign this to me ?

@curquiza
Copy link
Member Author

curquiza commented Feb 9, 2023

Of course! Thank you very much @waveywaves

@waveywaves waveywaves mentioned this issue Feb 10, 2023
Merged
3 tasks
@bors bors bot closed this as completed in c88b6f3 Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@waveywaves waveywaves

Labels
bug Something isn't working as expected tooling Not directly project related, like Docker, Homebrew...
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Optimize meilisearch uffizzi build waveywaves/meilisearch
2 participants
@waveywaves @curquiza