Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancelling an indexing task does not always stop indexing quickly #3715

Open
loiclec opened this issue May 1, 2023 · 2 comments
Open

Cancelling an indexing task does not always stop indexing quickly #3715

loiclec opened this issue May 1, 2023 · 2 comments
Labels
bug Something isn't working as expected indexing

Comments

@loiclec
Copy link
Contributor

loiclec commented May 1, 2023

In Meilisearch v1.1, cancelling an indexing task is not guaranteed to stop the task quickly.
There are a few indexing phases which do not listen for the cancellation signal (for example, within the data extractors) and therefore a user may have to wait a very long time for indexing to stop. See this bug report.

We should try to implement cancellation during every indexing phase so that cancelling an indexing task immediately stops it.

@loiclec loiclec added bug Something isn't working as expected indexing labels May 1, 2023
@loiclec loiclec changed the title Cancelling an indexing task takes too long Cancelling an indexing task does not always stop indexing quickly May 1, 2023
@dureuill
Copy link
Contributor

dureuill commented Jul 11, 2023

Ping from triage

  • Severity: very low
  • Size: medium to discover and fix some low hanging fruits. Very difficult to ensure that we won't introduce other bottlenecks in the future. Maintenance work.
  • impact: performance degradation, increased latency to work on new tasks

@curquiza
Copy link
Member

FYI: also this issue has been opened related to the topics #4358

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected indexing
Projects
None yet
Development

No branches or pull requests

3 participants