Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic using hybrid search #4588

Open
sam-ulrich1 opened this issue Apr 18, 2024 · 6 comments
Open

Panic using hybrid search #4588

sam-ulrich1 opened this issue Apr 18, 2024 · 6 comments
Labels
bug Something isn't working as expected needs more info This issue needs a minimal complete and verifiable example

Comments

@sam-ulrich1
Copy link

I've confirmed that there is a valid embedding being sent and a valid query

2024-04-18T22:38:19.654577Z ERROR meilisearch: info=panicked at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/arroy-0.2.0/src/reader.rs:250:83: called `Option::unwrap()` on a `None` value
2024-04-18T22:38:19.654906Z ERROR HTTP request{method=POST host="meili-meilisearch.gigo-core.svc.cluster.local:7700" route=/indexes/bytes/search query_parameters= user_agent=Meilisearch Go (v0.26.2) status_code=500 error=task 595 panicked}: tracing_actix_web::middleware: Error encountered while processing the incoming HTTP request: ResponseError { code: 500, message: "task 595 panicked", error_code: "internal", error_type: "internal", error_link: "https://docs.meilisearch.com/errors#internal" }
2024-04-18T22:38:19.655012294Z 2024-04-18T22:38:19.654962Z  INFO HTTP request{method=POST host="meili-meilisearch.gigo-core.svc.cluster.local:7700" route=/indexes/bytes/search query_parameters= user_agent=Meilisearch Go (v0.26.2) status_code=500 error=task 595 panicked}: meilisearch: close time.busy=669µs time.idle=7.79ms
2024-04-18T22:38:19.658533Z ERROR meilisearch: info=panicked at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/arroy-0.2.0/src/reader.rs:250:83: called `Option::unwrap()` on a `None` value
2024-04-18T22:38:19.658727629Z 2024-04-18T22:38:19.658687Z ERROR HTTP request{method=POST host="meili-meilisearch.gigo-core.svc.cluster.local:7700" route=/indexes/bytes/search query_parameters= user_agent=Meilisearch Go (v0.26.2) status_code=500 error=task 597 panicked}: tracing_actix_web::middleware: Error encountered while processing the incoming HTTP request: ResponseError { code: 500, message: "task 597 panicked", error_code: "internal", error_type: "internal", error_link: "https://docs.meilisearch.com/errors#internal" }
@sam-ulrich1
Copy link
Author

I dropped the whole index and re-created it and now it doesn't happens so it looks like some form of data corruption issue

@sam-ulrich1
Copy link
Author

@Kerollmops I guess you're confused? Not sure how to take an emoji

@Kerollmops
Copy link
Member

I am just reacting to the issue. Yes, there is a panic in the engine, it seems related to Arroy and we will fix it soon.

@curquiza curquiza added the bug Something isn't working as expected label Apr 22, 2024
@curquiza curquiza added this to the v1.8.0 milestone Apr 22, 2024
@curquiza curquiza added needs more info This issue needs a minimal complete and verifiable example and removed needs more info This issue needs a minimal complete and verifiable example labels Apr 29, 2024
@irevoire
Copy link
Member

irevoire commented May 2, 2024

Hey @sam-ulrich1, sorry I’m a little late to the party, but I was wondering, do you have any snapshots or dumps of the data that corrupted your database?

Also, which version of meilisearch were you using, and did you do any updates while you had vectors in your DB?

@sam-ulrich1
Copy link
Author

I do not have any dumps for this point in time. I can describe the procedure that led to it. Pretty simple.

  • New Index
  • Ingest ~1000 new vectors @ 1024 dim
  • Perform about 30 searches on it

I'm sure something else contributed though because I dropped the index and recreated with the same steps and it did not corrupt again

@irevoire
Copy link
Member

irevoire commented May 2, 2024

Thanks a lot for the answer!
Two last questions:

  • Which version of meilisearch were you using?
  • Did you send the 1000 vectors in one document addition or in multiple additions (and if it’s in multiple additions, do you have an idea of the number of vectors per document addition?)

@curquiza curquiza added the needs more info This issue needs a minimal complete and verifiable example label May 6, 2024
@curquiza curquiza removed this from the v1.8.0 milestone May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected needs more info This issue needs a minimal complete and verifiable example
Projects
None yet
Development

No branches or pull requests

4 participants