Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows tests routinely fail #4662

Open
dureuill opened this issue May 29, 2024 · 2 comments
Open

Windows tests routinely fail #4662

dureuill opened this issue May 29, 2024 · 2 comments
Labels
maintenance Issue about maintenance (CI, tests, refacto...) windows Issue related to the Windows platform

Comments

@dureuill
Copy link
Contributor

"Tests-on-Windows-2022" fails with an error indicating no free space, see e.g. #4647

For now we can disable the tests, but we should find out what happens during the pre-release cycle!

@dureuill dureuill added windows Issue related to the Windows platform maintenance Issue about maintenance (CI, tests, refacto...) labels May 29, 2024
@dureuill dureuill added this to the v1.9.0 milestone May 29, 2024
@dureuill
Copy link
Contributor Author

dureuill commented May 29, 2024

Some initial investigations

  • only one test fails: perform_snapshot
  • the test enters an infinite loop of prints because it waits for a task to complete, but only checks for the successful exit condition, not the case where the snapshot would fail
  • There is plenty of space on both C: and D:, but the tests uses a temp directory, and I don't know where this is stored on Windows by default, especially in the runner like this.
  • that test was recently modified as part of Split the field id map from the weight of each fields #4631, so maybe there are some lingering issues here

@dureuill
Copy link
Contributor Author

Added 2cf3e1c to ignore the perform_snapshot test as a stopgap

@curquiza curquiza removed this from the v1.9.0 milestone Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Issue about maintenance (CI, tests, refacto...) windows Issue related to the Windows platform
Projects
None yet
Development

No branches or pull requests

2 participants