Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<em> tags present inside arrays #92

Closed
mdubus opened this issue Jul 5, 2021 · 5 comments
Closed

<em> tags present inside arrays #92

mdubus opened this issue Jul 5, 2021 · 5 comments
Labels
bug Something isn't working freezed

Comments

@mdubus
Copy link
Member

mdubus commented Jul 5, 2021

What's wrong ?

Highlight doesn't seem to work inside arrays.

Output on the dashboard:
Capture d’écran 2021-07-05 à 15 35 24

Output from MeiliSearch:

    {
      "Title": "Brazilian Musicians",
      "Artist": "Tomas Santa Rosa Junior",
      "Nationality": [
        "Brazilian"
      ],
      "Gender": [
        "Male"
      ],
      "Date": "1941"
  }

What's the expected behaviour ?

The element inside the array should either be highlighted, or not have the <em> tag

How to test

Use the Moma database:

@mdubus mdubus added the bug Something isn't working label Jul 5, 2021
@mdubus
Copy link
Member Author

mdubus commented Jul 6, 2021

Relative to the v0.21 of MeiliSearch (bug not present in the v0.20).
Waiting for the highlight to be fixed in the v0.21 & upgrade of instant-meilisearch.

@mdubus mdubus added the freezed label Jul 6, 2021
@Kerollmops
Copy link
Member

Kerollmops commented Jul 6, 2021

Not sure about the bug you are talking about here. There indeed is a bug where the highlighted length of the tokens is invalid but I don't think it is blocking you on this task. You can implement the highlighting of arrays. 😄

@mdubus
Copy link
Member Author

mdubus commented Jul 6, 2021

Not sure about the bug you are talking about here. There indeed is a bug where the highlighted length of the tokens is invalid but I don't think it is blocking you on this task. You can implement the highlighting of arrays. 😄

Sorry I heard that the highlight had a few problems with the v0.21, so I assumed that the problem came from there. After investigating further more, it seems to be caused by Instant MeiliSearch and not MeiliSearch itself.

I'll have to wait for Instant MeiliSerch to be up-to-date with the v0.21 to see if it fixes the problem

@mdubus mdubus changed the title Highlight doesn't work inside arrays <em> tags present inside arrays Jul 6, 2021
@mdubus
Copy link
Member Author

mdubus commented Jul 6, 2021

Related to meilisearch/meilisearch-js-plugins#435

@mdubus
Copy link
Member Author

mdubus commented Oct 12, 2021

Fixed with meilisearch/meilisearch-js-plugins#531 and the upgrade of instant-meilisearch

@mdubus mdubus closed this as completed Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working freezed
Projects
None yet
Development

No branches or pull requests

2 participants