Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rating or Filter is not working for me #163

Closed
AwesomeAustn opened this issue Apr 3, 2021 · 6 comments · Fixed by #165
Closed

Rating or Filter is not working for me #163

AwesomeAustn opened this issue Apr 3, 2021 · 6 comments · Fixed by #165
Assignees
Labels
bug Bug is with Plex Meta Manager

Comments

@AwesomeAustn
Copy link

rating.gte or filter is not working for me.

Good Comedy:
  plex_search:
    genre: Comedy
  filters:
    rating.gte: 8
  sync_mode: sync
  collection_mode: default
  collection_order: alpha
  sort_title: '*201'
  summary: A collection of Comedy TV Shows with a rating of 8 and higher
|   File "/modules/config.py", line 462, in update_libraries
|     builder.run_methods(collection_obj, collection_name, rating_key_map, movie_map, show_map)
|   File "/modules/builder.py", line 876, in run_methods
|     if len(items) > 0:                                  rating_key_map = self.library.add_to_collection(collection_obj if collection_obj else collection_name, items, self.filters, self.details["show_filtered"], rating_key_map, movie_map, show_map)
|   File "/modules/plex.py", line 213, in add_to_collection
|     if (modifier == ".lte" and attr > filter_data) or (modifier == ".gte" and attr < filter_data):
| TypeError: '<' not supported between instances of 'NoneType' and 'float'

It processes 24 shows and then gives the error. For my Drama one, it only processes one show. It stops at the same point every time.

@meisnate12
Copy link
Member

i think ive already fixed this in develop if you wanted to switch and see

@AwesomeAustn
Copy link
Author

Thanks! I'll switch over.

@AwesomeAustn
Copy link
Author

| Scanning Good Comedy Collection                                                                    |
| Collection Warning: rating.gte filter will run as critic_rating.gte                                |
|                                                                                                    |
| Sync Mode: sync                                                                                    |
|                                                                                                    |
| Collection Filter critic_rating.gte: 8.0                                                           |
|                                                                                                    |
| Processing Plex Search: genre(Comedy)                                                              |
| Unknown Error: 'Show' object has no attribute 'critic_rating'                                      |

meisnate12 added a commit that referenced this issue Apr 3, 2021
@meisnate12
Copy link
Member

fix is in develop. Also plex_search is much faster then using filters. i would suggest this:

Good Comedy:
  plex_search:
    genre: Comedy
    critic_rating.greater: 8
  sync_mode: sync
  collection_mode: default
  collection_order: alpha
  sort_title: '*201'
  summary: A collection of Comedy TV Shows with a rating of 8 and higher

Also this search above currently only works in develop

@AwesomeAustn
Copy link
Author

Thank you!

@meisnate12
Copy link
Member

leaving open until pushed to master

@meisnate12 meisnate12 reopened this Apr 3, 2021
@meisnate12 meisnate12 added the bug Bug is with Plex Meta Manager label Apr 5, 2021
@meisnate12 meisnate12 self-assigned this Apr 5, 2021
@meisnate12 meisnate12 mentioned this issue Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug is with Plex Meta Manager
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants