New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plex_search "genre not found" error ignores genre requirement and continues with search #239
Comments
having it automatically fail the whole search was my initial intention but I got requested to allow it to continue. In either case the real solution is to just properly give the correct attributes and then there's no problem at all. but other then that I'm really not sure why it failed to find the action genre. Can you verify that it is a genre in your library and the its spelled exactly the same. Finally my honest recommendation for this type of collection is to switch it to a smart collection, which can be done complete in plex |
Well it should definitely continue the script without crashing, but to continue creating the collection while ignoring one of the requirements doesn't make sense... It failed to find Action and Adventure because Plex took it upon themselves to decide that those genre's are the same and combined them into an "Action/Adventure" genre in their new Beta TV Agent. I can look into smart collections later, but IDK how to do that yet, so for now it's easier to comment out this specific collection block in my YML |
The reasoning was using a template for actor director producer and writer and then being able to just give it a person to include any movies that have any of those conditions and with it the way you're describing that collection would error out. |
It wouldn't, or we couldn't, just translate the "actor/director/producer/writer not found" errors to a false match and move on? You're the main guy working on this, so I'm sure you know what you're talking about. It's just hard for me to picture why this would be an issue with my general knowledge of programming. |
Also if you don't like those genres PMM has a mass_update_genres feature you might be interested in And smart collections are absolutely amazing it doesn't take the place of PMM completely but it should be able to take the place of any plex_search |
It's more of one way or the other unless I specifically like make a new term let's say crew and have it function different then how all the others work, which is actually the route im leaning torwards |
I'm wasting a bunch of time opening random wiki pages and Ctrl+F'ing this stuff... Do you know the URL to the wiki pages for mass_update_genres and smart collections? |
Mass_genre_update is I wanna say on the library attribute page |
ok i added |
I have a genre collection:
With Plex's new beta TV agent, they've removed the Action and Adventure genre's so the genre throws an error:
The script continues without crashing, but now all of the sudden it's adding everything that's not in collection Anime while ignoring the previous genre requirement.
I think it would make more sense if plex_search fails to find a genre, network, or any other field that needs to be exact, that the entire search fails.
The text was updated successfully, but these errors were encountered: