Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Low Storage Space after running PMM #241

Closed
ngInit opened this issue May 12, 2021 · 10 comments · Fixed by #240
Closed

Low Storage Space after running PMM #241

ngInit opened this issue May 12, 2021 · 10 comments · Fixed by #240
Assignees
Labels
enhancement New feature or request

Comments

@ngInit
Copy link

ngInit commented May 12, 2021

I noticed about 250GB missing today and realized it's related to old Plex metadata bundles. It would be nice if there was an option to automatically run the Optimize Database and Clean Bundles functions located in Plex Server Settings > Troubleshooting after PMM is finished.

@meisnate12 meisnate12 self-assigned this May 12, 2021
@meisnate12 meisnate12 added the enhancement New feature or request label May 12, 2021
@meisnate12
Copy link
Member

meisnate12 commented May 12, 2021

added clean_bundles, empty_trash, and optimize to the plex attribute and by default, they're set to false. If these are true PMM will run the specified operation on the library at the end of the run

@meisnate12 meisnate12 mentioned this issue May 12, 2021
@ngInit
Copy link
Author

ngInit commented May 12, 2021

Does it empty trash first?

It doesn't look like it does. You'd want that first so clean_bundles gets the fresh trash.

There might also be a timing issue there... But it shouldn't actually break anything if there is, you just wouldn't have all the trash emptied.

@meisnate12
Copy link
Member

i always thought the order of doing those didn't matter but its in this order

  1. clean_bundles
  2. empty_trash
  3. optimize

@meisnate12
Copy link
Member

i figured if it didnt do everything that day well it should finish up the next

@ngInit
Copy link
Author

ngInit commented May 12, 2021

Yeah it wouldn't make a difference unless you decide to add something that waits until the trash finished being emptied before calling optimize and clean_bundles

@meisnate12
Copy link
Member

i could put in a wait but I don't think there's a way for me to know that its done all I could do is base it on time

@ngInit
Copy link
Author

ngInit commented May 12, 2021

Sometimes it takes the trash awhile to empty if you're changing a lot of things... A wait wouldn't do much good if it couldn't be accurate 🤔

One possibility could be letting the user set an optional wait time themselves. Users with large libraries could figure out the average trash empty time and add the delay, and smaller libraries wouldn't really need it

@meisnate12
Copy link
Member

everything leftover will just get cleaned up the next day anyways so I don't think its really needed

@ngInit
Copy link
Author

ngInit commented May 12, 2021

Yeah, either way having this is way better than before 👍

@ngInit ngInit closed this as completed May 12, 2021
@meisnate12
Copy link
Member

im gonna leave this open untill i merge 1.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants