Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Add periods to Trakt listings #418

Closed
c4mz opened this issue Oct 25, 2021 · 7 comments · Fixed by #431
Closed

Feature Request: Add periods to Trakt listings #418

c4mz opened this issue Oct 25, 2021 · 7 comments · Fixed by #431
Assignees
@meisnate12
Labels
enhancement New feature or request status:added-to-develop Feature Request or Bug Fix is in Develop

Comments

@c4mz
Copy link

c4mz commented Oct 25, 2021

Hi, is it possible to add the period filters to the 'recommended' 'watched' 'collected' lists.

Filters would be: daily, monthly, yearly, all

eg. https://trakt.tv/movies/watched/daily

Cheers!
@c4mz c4mz added enhancement New feature or request status:not-yet-viewed I haven't reviewed the Feature or Bug yet labels Oct 25, 2021
meisnate12 added a commit that referenced this issue Oct 25, 2021
@meisnate12
#418 Added period to trakt_recommended, trakt_watched , and trakt_col…
309f2d5 
…lected
@meisnate12 meisnate12 added status:added-to-develop Feature Request or Bug Fix is in Develop and removed status:not-yet-viewed I haven't reviewed the Feature or Bug yet labels Oct 25, 2021
@meisnate12
Copy link
Member

this was actually really easy its done in develop

@c4mz
Copy link
Author

c4mz commented Oct 25, 2021

You're awesome.

@meisnate12
Copy link
Member

meisnate12 commented Oct 25, 2021 •
edited

new trakt builders trakt_collected_daily, trakt_collected_weekly, trakt_collected_monthly, trakt_collected_yearly, trakt_collected_all, trakt_recommended_daily, trakt_recommended_weekly, trakt_recommended_monthly, trakt_recommended_yearly, trakt_recommended_all, trakt_watched_daily, trakt_watched_weekly, trakt_watched_monthly, trakt_watched_yearly, trakt_watched_all

trakt_collected will now run as trakt_collected_weekly
trakt_recommended will now run as trakt_recommended_weekly
trakt_watched will now run as trakt_watched_weekly

@c4mz
Copy link
Author

c4mz commented Oct 25, 2021 •
edited

Does this need to be added?

"trakt_collected_daily", "trakt_collected_weekly", "trakt_collected_monthly", "trakt_collected_yearly", "trakt_collected_all",
"trakt_recommended_daily", "trakt_recommended_weekly", "trakt_recommended_monthly", "trakt_recommended_yearly", "trakt_recommended_all",
"trakt_watched_daily", "trakt_watched_weekly", "trakt_watched_monthly", "trakt_watched_yearly", "trakt_watched_all",
"trakt_collection", "trakt_list", "trakt_list_details", "trakt_popular", "trakt_trending", "trakt_watchlist"

to line 149 in builder.py

to support custom_sort_builders

@meisnate12
Copy link
Member

yes its been added

@c4mz c4mz closed this as completed Oct 26, 2021
@meisnate12
Copy link
Member

i leave these open until the feature is in the main branch

@meisnate12 meisnate12 reopened this Oct 26, 2021
@c4mz
Copy link
Author

c4mz commented Oct 26, 2021

Ahh sorry my bad.

@meisnate12 meisnate12 mentioned this issue Nov 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meisnate12 meisnate12

Labels
enhancement New feature or request status:added-to-develop Feature Request or Bug Fix is in Develop
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v1.13.0 Kometa-Team/Kometa
2 participants
@meisnate12 @c4mz