Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Episode object fails to reload when found by ID #3

Closed
CollinHeist opened this issue Jul 9, 2022 · 1 comment
Closed

[Bug]: Episode object fails to reload when found by ID #3

CollinHeist opened this issue Jul 9, 2022 · 1 comment
Assignees
Labels
bug Bug is with TMDbAPIs status:not-yet-viewed I haven't eeviewed the Feature or Bug yet

Comments

@CollinHeist
Copy link

Version Number

1.0.5

Describe the Bug

An Episode object returned by find_by_id() raises NotFound when reloaded, despite obviously being found by the find method, and existing on TMDb.


I've noticed it with The Boys, S03E08. Reproduced below:

from tmdbapis import TMDbAPIs

api_key = # ...
api = TMDbAPIs(api_key)

# This way works and the episode can be reloaded
ep = api.tv_episode(76479, 3, 8) 
print(ep)
# Prints [3435049:The Instant White-Hot Wild]
ep.reload() # No error

# This way does not work
ep = api.find_by_id(tvdb_id=8932006).tv_episode_results[0]
print(ep)
# Prints [3435049:The Instant White-Hot Wild]
ep.reload()
# Raises *** tmdbapis.exceptions.NotFound: (404 [Not Found]) Requested Item Not Found

Obviously does not happen with all episodes returned by this method.

@CollinHeist CollinHeist added bug Bug is with TMDbAPIs status:not-yet-viewed I haven't eeviewed the Feature or Bug yet labels Jul 9, 2022
CollinHeist added a commit to CollinHeist/TitleCardMaker that referenced this issue Jul 10, 2022
- Temporary fix for Kometa-Team/TMDbAPIs#3
- Strictly set TMDbAPIs package version to 1.0.5
@CollinHeist
Copy link
Author

Looks like this was fixed in e70792e - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug is with TMDbAPIs status:not-yet-viewed I haven't eeviewed the Feature or Bug yet
Projects
None yet
Development

No branches or pull requests

2 participants