Skip to content

Commit

Permalink
Merge pull request #42 from bitleak/feature/log-format
Browse files Browse the repository at this point in the history
ADD: log format config
  • Loading branch information
git-hulk committed Jul 13, 2020
2 parents d470722 + 0bc8987 commit 79f8906
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 2 deletions.
1 change: 1 addition & 0 deletions config/config.go
Expand Up @@ -28,6 +28,7 @@ type Config struct {
AdminPort int
LogLevel string
LogDir string
LogFormat string
EnableAccessLog bool
AdminRedis RedisConf
Pool RedisPool
Expand Down
1 change: 1 addition & 0 deletions config/demo-conf.toml
Expand Up @@ -4,6 +4,7 @@ AdminHost = "127.0.0.1" # optional, default to localhost
AdminPort = 7778
#LogDir = "/var/log/lmstfy"
LogLevel = "info"
#LogFormat = "text" # Use LogFormat="json" if wants to print the log with json format
EnableAccessLog = true

# default params
Expand Down
8 changes: 7 additions & 1 deletion log/utils.go
Expand Up @@ -34,7 +34,7 @@ func ReopenLogs(logDir string, accessLogger, errorLogger *logrus.Logger) error {
}

// @backtrackLevel: log the backtrack info when logging level is >= backtrackLevel
func SetupLogger(logDir, logLevel, backtrackLevel string) (accessLogger *logrus.Logger, errorLogger *logrus.Logger, err error) {
func SetupLogger(logFormat, logDir, logLevel, backtrackLevel string) (accessLogger *logrus.Logger, errorLogger *logrus.Logger, err error) {
level, err := logrus.ParseLevel(logLevel)
if err != nil {
return nil, nil, fmt.Errorf("failed to parse log level: %s", err)
Expand All @@ -45,6 +45,12 @@ func SetupLogger(logDir, logLevel, backtrackLevel string) (accessLogger *logrus.
}
accessLogger = logrus.New()
errorLogger = logrus.New()

if logFormat == "json" {
accessLogger.SetFormatter(&logrus.JSONFormatter{})
errorLogger.SetFormatter(&logrus.JSONFormatter{})
}

errorLogger.Level = level
errorLogger.Hooks.Add(NewBackTrackHook(btLevel))
if logDir == "" {
Expand Down
2 changes: 1 addition & 1 deletion server/main.go
Expand Up @@ -169,7 +169,7 @@ func main() {
panic(fmt.Sprintf("Failed to load config file: %s", err))
}
shutdown := make(chan struct{})
accessLogger, errorLogger, err := log.SetupLogger(conf.LogDir, conf.LogLevel, Flags.BackTrackLevel)
accessLogger, errorLogger, err := log.SetupLogger(conf.LogFormat, conf.LogDir, conf.LogLevel, Flags.BackTrackLevel)
if err != nil {
panic(fmt.Sprintf("Failed to setup logger: %s", err))
}
Expand Down

0 comments on commit 79f8906

Please sign in to comment.