Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MOD: add republish, ack and publish job atomic #33

Merged
merged 4 commits into from
Apr 17, 2020
Merged

MOD: add republish, ack and publish job atomic #33

merged 4 commits into from
Apr 17, 2020

Conversation

liguangbo
Copy link
Collaborator

FIX #32

@liguangbo liguangbo added the enhancement New feature or request label Apr 17, 2020
@liguangbo liguangbo requested a review from git-hulk April 17, 2020 08:39
git-hulk
git-hulk requested changes Apr 17, 2020
View reviewed changes
server/handlers/queue_test.go Outdated Show resolved Hide resolved
git-hulk
git-hulk approved these changes Apr 17, 2020
View reviewed changes
Copy link
Member

@git-hulk git-hulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@git-hulk git-hulk merged commit 56f512d into master Apr 17, 2020
@liguangbo liguangbo deleted the feature/republish branch April 17, 2020 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@git-hulk git-hulk git-hulk approved these changes

Assignees

@git-hulk git-hulk

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Atomic publish and ack
2 participants
@liguangbo @git-hulk