Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD: publish/consume throttler API #36

Merged
merged 4 commits into from
Jun 2, 2020
Merged

ADD: publish/consume throttler API #36

merged 4 commits into from
Jun 2, 2020

Conversation

git-hulk
Copy link
Member

the throttler only limits the consume/publish QPS instead of messages, don't use batch consume if you want to limit the rate of message.

@git-hulk git-hulk requested a review from liguangbo May 31, 2020 06:46
@git-hulk git-hulk force-pushed the feature/throttler branch 3 times, most recently from 5e4307d to 5ba8958 Compare May 31, 2020 07:27
Copy link
Collaborator

@liguangbo liguangbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

server/handlers/admin.go Outdated Show resolved Hide resolved
server/handlers/admin.go Outdated Show resolved Hide resolved
throttler/throttler.go Outdated Show resolved Hide resolved
@git-hulk
Copy link
Member Author

git-hulk commented Jun 1, 2020

resolved #35

@liguangbo liguangbo merged commit ecb500a into master Jun 2, 2020
@git-hulk git-hulk deleted the feature/throttler branch February 28, 2021 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants