modify review

command/sets.go

@@ -239,8 +239,8 @@ func SInter(ctx *Context, txn *db.Transaction) (OnCommit, error) {
 		return nil, errors.New("ERR " + err.Error())
 	}
 
-	for _, val := range setlist[1:] {
-		set, err := txn.Set([]byte(val.Key))
+	for _, key := range setlist[1:] {
+		set, err := txn.Set([]byte(key.Key))
 		if err != nil {
 			return nil, errors.New("ERR " + err.Error())
 		}
@@ -259,8 +259,8 @@ func SDiff(ctx *Context, txn *db.Transaction) (OnCommit, error) {
 	var keys [][]byte
 	var members [][]byte
 
-	key := []byte(ctx.Args[0])
-	set, err := txn.Set(key)
+	ks := []byte(ctx.Args[0])
+	set, err := txn.Set(ks)
 	if err != nil {
 		return nil, errors.New("ERR " + err.Error())
 	}

db/set.go

@@ -154,9 +154,8 @@ func RemoveRepByMap(members [][]byte) [][]byte {
 	// tempMap saves non-repeating primary keys
 	tempMap := map[string]int{}
 	for _, m := range members {
-		l := len(tempMap)
-		tempMap[string(m)] = 0
-		if len(tempMap) != l {
+		_, ok := tempMap[string(m)]
+		if !ok {
 			result = append(result, m)
 		}
 	}
@@ -328,9 +327,6 @@ func (set *Set) SMove(destination []byte, member []byte) (int64, error) {
 			return 0, err
 		}
 		destset.meta.Len++
-		if err := destset.updateMeta(); err != nil {
-			return 0, err
-		}
 	}
 	dkey := DataKey(set.txn.db, set.meta.ID)
 	ikey := setItemKey(dkey, member)