Implement redis command 'BITOP' and 'BITFIELD'. #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…API array2() that can combine multiple RESP types into one array; 2. Delete IntegerArray() function, use Array() instead;
![codelingo[bot]](https://avatars.githubusercontent.com/in/14339?s=60&v=4){kind=small}
zyy17
requested review from
shafreeck and
YIDWang
and removed request for
shafreeck
shafreeck
reviewed
Mar 19, 2019
| ) | ||
|
|
||
| // The 'Value' design is referenced from https://github.com/tidwall/resp | ||
| type Value struct { |
There was a problem hiding this comment.
Is the design of Value really necessary, it is a conflict style with the original design. Maybe we should think again and supply more reasons to change the design.
There was a problem hiding this comment.
I will change the PR to use the original way to construct response.
shafreeck
requested review from
shafreeck
and removed request for
YIDWang and
shafreeck
YIDWang
approved these changes
Apr 10, 2019
|
|
||
| const ( | ||
| SimpleString Type = '+' | ||
| Error Type = '-' |
There was a problem hiding this comment.
This feature is currently supported in the package. Is this necessary？
|
ping @GhostComputing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bitop;bitfield;Array()to output array that combines with multiple resp types.