Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore node status booted by Slurm #36

Closed
mehdid opened this issue Jun 28, 2017 · 3 comments
Closed

Ignore node status booted by Slurm #36

mehdid opened this issue Jun 28, 2017 · 3 comments

Comments

@mehdid
Copy link

mehdid commented Jun 28, 2017

Changing state of booting nodes when botted by Slurm energy saving feature can mess up with Slurm node state power flags. To avoid this issue, the patch below makes NHC ignore node with state "idle#" in order to avoid offlining them.

A tested patch is available at: https://github.com/edf-hpc/warewulf-nhc/blob/master/debian/patches/0003-ignore-node-status-booted-by-slurm.patch

@mej
Copy link
Owner

mej commented Jun 28, 2017

Would it maybe make sense to ignore states matching *[\*\#@] in node-mark-offline?

@mej mej self-assigned this Jun 28, 2017
@mej mej added this to the 1.4.3 Release milestone Jun 28, 2017
@mehdid
Copy link
Author

mehdid commented Jun 30, 2017

As '#' denotes all nodes being powered up, I think your suggestion makes sense and covers all possible states, including idle#. But so far, we've only got the issue with idle#.

@mej
Copy link
Owner

mej commented Apr 18, 2021

I'm going to address this in at least 2, and most likely 3, different ways among the upcoming release versions. In order to avoid duplicating lots of stuff, I'm going to to close this issue in favor of #84 and use that to track the conversation overall. But FWIW, I plan to address this in all 3 versions (1.4.3, 1.4.4, and 1.5)!

@mej mej closed this as completed Apr 18, 2021
NHC 1.4.3 Release automation moved this from Triage / TODO to Completed / Merged Apr 18, 2021
NHC 1.5 Release automation moved this from Triage / TODO to Completed / Merged Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
NHC 1.4.3 Release
  
Completed / Merged
NHC 1.5 Release
  
Completed / Merged
Development

No branches or pull requests

2 participants