IFluidHandlerWrapper implementation cleanup #5551
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
@Nullable
to@Nonnull
canDrain
andcanFill
get called beforedrain
andfill
respectively.canDrain
already checked the type is correctdrain
method forTileEntityTurbineVent
as previously onlycanDrain
was implemented.EmitUtils#forEachSide
to ensure the tile it is trying to eject to is loaded.This PR fixes #5550 and various other oddities with our fluid handlers by cleaning up the IFluidHandlerWrapper code a good bit making it easier to read/manage.