Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Wood Gasification to atleast for logs and dust return coal dust #6241

Merged
merged 3 commits into from Jul 1, 2020

Conversation

ToMe25
Copy link
Contributor

@ToMe25 ToMe25 commented Jun 26, 2020

Changes proposed in this pull request:

  • Update the log and dust wood gasification recipes to use the equivalent of two logs, and return one charcoal dust.
  • Add stair wood gasification recipes
  • rebalance plank, slab and stick wood gasification recipes, to not result in more then the wood they are made of
  • move coal gasification recipes to their own directory

Questions:

  • Should the dust recipe require more sawdust? you can get up to 37.75 sawdust from one log, while currently one sawdust is worth 1/8 of a log.
  • should more recipes be increased in size to the equivalent of 2 logs and result in a charcoal dust?
  • should the plank, slab and stick recipes even be rebalanced, or were they fine before because you need energy to convert the wood anyways?

This was planned from the beginning, but mekanism had no charcoal dust
back then.
@pupnewfster pupnewfster added this to the 9.10.9 milestone Jun 26, 2020
@pupnewfster
Copy link
Member

I think it probably does make sense to balance them closer to the actual values, if a log is worth roughly 37.75 sawdust it probably makes sense to have it use either four or five (I will leave this up to you as you seem to know move about how gasification works in real life).

@ToMe25
Copy link
Contributor Author

ToMe25 commented Jun 29, 2020

I don't know that much, but some time back, shortly before i implemented it originally i read alot about it, because it interested me at the time.
Also i wouldn't make it 36 sawdust per log value, because that is the absolute max you can get and requires a few sawmills.
I would say 32 sawdust seems fair, also that would allow the input for alteast 2 recipes.
Also i would use 4 logs then, that should make it easier to handle, but this would mean i can't make the dust recipe return any charcoal dust, if each log is worth 32 sawdust.
So should it be
a) 4 logs per charcoal and nothing else returns any charcoal dust,
b) 2 logs per charcoal and the dust recipe returns a charcoal dust,
c) 4 logs per charcoal and the plank recipe returns charcoal instead of the dust one

Now the plank recipe results in charcoal instead of the dust one.
This undoes the changes to the slab recipe
@ToMe25
Copy link
Contributor Author

ToMe25 commented Jun 29, 2020

This implements c.
Also i missed something, so the PR isn't finished :)

* Decrease sawdust recipe stack size
* Increase stick recipe stack size
* Fix stair recipe
@ToMe25
Copy link
Contributor Author

ToMe25 commented Jun 29, 2020

This PR should now be finished.

@pupnewfster pupnewfster merged commit 6fe9bce into mekanism:1.15x Jul 1, 2020
aidancbrady added a commit that referenced this pull request Jul 1, 2020
* 'v10' of https://github.com/mekanism/Mekanism:
  Update state_holder.png
  Updated Generators Sun Icons
  Fix merge conflicts
  Fix read/write location mismatch for retrogen
  Update Wood Gasification to atleast for logs and dust return coal dust (#6241)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants