Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ComfyUI Simlink Failure[bug] #26

Closed
Piscabo opened this issue Jul 17, 2023 · 8 comments · Fixed by #22
Closed

ComfyUI Simlink Failure[bug] #26

Piscabo opened this issue Jul 17, 2023 · 8 comments · Fixed by #22

Comments

@Piscabo
Copy link

Piscabo commented Jul 17, 2023

Describe the bug

Log level: 20
[comfy_mtb] | ERROR -> Failed to create symlink to C:\AI_Files\ComfyUI_windows_portable\ComfyUI\web\extensions\mtb. Please copy the folder manually.

Reproduction

  1. Install MTB Node and Controlnet
  2. Symlink failure when the server starts
  3. Copy mtb to ComfyUI_windows_portable\ComfyUI\web\extensions
  4. Restart the server, but symlink still fails

Expected behavior

After copying the full folder to the suggested position no error should occur.

Platform and versions

Windows 11
ComfyUI Standalone "https://github.com/comfyanonymous/ComfyUI/releases"

Console output

Log level: 20
[comfy_mtb] | ERROR -> Failed to create symlink to C:\AI_Files\ComfyUI_windows_portable\ComfyUI\web\extensions\mtb. Please copy the folder manually.
[comfy_mtb] | ERROR -> Some nodes failed to load:
        Failed to import faceenhance because ModuleNotFoundError: No module named 'basicsr'
        Failed to import faceswap because ModuleNotFoundError: No module named 'insightface'
        Failed to import fun because ModuleNotFoundError: No module named 'qrcode'
        Failed to import image_interpolation because ModuleNotFoundError: No module named 'tensorflow'

Check that you properly installed the dependencies.
If you think this is a bug, please report it on the github page (https://github.com/melMass/comfy_mtb/issues)

Additional context

No response

@Piscabo Piscabo added status: 🧹 needs triage This issue needs to triage, applied to new issues type: 🐛 bug Something isn't working labels Jul 17, 2023
@melMass melMass added status: 🧪 needs testing and removed status: 🧹 needs triage This issue needs to triage, applied to new issues labels Jul 17, 2023
@melMass
Copy link
Owner

melMass commented Jul 17, 2023

Thanks for the report.

Can you confirm the path is where you did copy the web folder manually?

This is actually optional, I will replace error by a warning to avoid confusion.

The other errors though indicate that the dependencies are not installed for these specific nodes. If you don't need them you can just ignore it, I made it so that part of the extension can fail to register.

@melMass melMass linked a pull request Jul 17, 2023 that will close this issue
5 tasks
@Piscabo
Copy link
Author

Piscabo commented Jul 18, 2023

ComfyUI\web\extensions\

image
image
And as soon as roop is installed, this happens?
image

@melMass
Copy link
Owner

melMass commented Jul 18, 2023

So the first screen you must copy the "web" folder to "mtb" not "comfy_mtb" inside the web extensions, I'll make that more obvious for when symlink fails.

The second error is probably due to another extension that rely on an older version of onnx, I believe mtb uses the most recent one 1.15.1, updating onnx might break that said extension...

It would be great to know which extension is causing this issue if you manage to find

@DarkCoverUnleashed
Copy link

    Failed to import faceenhance because ModuleNotFoundError: No module named 'basicsr'
    Failed to import faceswap because ModuleNotFoundError: No module named 'insightface'
    Failed to import fun because ModuleNotFoundError: No module named 'qrcode'
    Failed to import image_interpolation because ModuleNotFoundError: No module named 'tensorflow'

How do I install dependencies for these 4 . I have followed the install dependencies guide according to INSTALL.md .But still show this error.
thanks in advance

@Piscabo
Copy link
Author

Piscabo commented Jul 19, 2023

    Failed to import faceenhance because ModuleNotFoundError: No module named 'basicsr'
    Failed to import faceswap because ModuleNotFoundError: No module named 'insightface'
    Failed to import fun because ModuleNotFoundError: No module named 'qrcode'
    Failed to import image_interpolation because ModuleNotFoundError: No module named 'tensorflow'

How do I install dependencies for these 4 . I have followed the install dependencies guide according to INSTALL.md .But still show this error. thanks in advance

Just run the MTB requirements install from the python_embbed: (** where you have it installed...)
C:**\ComfyUI_windows_portable\python_embeded\python.exe -m pip install -r requirements.txt

@melMass
Copy link
Owner

melMass commented Jul 19, 2023

Exact! I'm taking a bit more time for the next release as I very recently discovered the manager which will be the recommended way to install mtb moving forward, I just need to tune a few things to take various setups into account. That should help with the install issues... 90% of the issues are about that 😅 , I'd rather dedicate time on the nodes

@Piscabo
Copy link
Author

Piscabo commented Jul 19, 2023

Exact! I'm taking a bit more time for the next release as I very recently discovered the manager which will be the recommended way to install mtb moving forward, I just need to tune a few things to take various setups into account. That should help with the install issues... 90% of the issues are about that 😅 , I'd rather dedicate time on the nodes

Wish I could help... but too dumb for that. But I'm a good tester... :-)
I have this error for the faceswap setup. (what model should I use?)
Error occurred when executing Load Face Swap Model (mtb):

[ONNXRuntimeError] : 7 : INVALID_PROTOBUF : Load model from C:\AI_Files\ComfyUI_windows_portable\ComfyUI\models\insightface\detection_mobilenet0.25_Final.pth failed:Protobuf parsing failed.

@melMass
Copy link
Owner

melMass commented Jul 19, 2023

For now only the inswapper_128.onnx model can be loaded from the loadModel, I should probably omit the detection models from this list, they are used by the faceswap node itself but not exposed, they will probably be used in a dedicated load node as requested in #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants