Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'roll0' typo in Create Action macro #30

Open
wallaby5716 opened this issue Dec 20, 2020 · 1 comment
Open

'roll0' typo in Create Action macro #30

wallaby5716 opened this issue Dec 20, 2020 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@wallaby5716
Copy link

Describe the bug
When creating an action with 'Create Action' and unchecking the 'Check if the character adds their proficiency bonus'. The final macro expression will say ([t: roll0 + StrMod + ...]). instead of the expected "([t: roll + StrMod + ...])"

To Reproduce

  1. Create Action
  2. Don't add proficiency bonus to the attack roll
  3. Run macro
  4. Be greeted with 'Enter a value for roll0'

Expected behavior
Macro runs flawlessly

Desktop (please complete the following information):

  • OS & Version: [I use arch btw]
  • MapTool Version: [e.g. 1.8.0 Beta 2]
@wallaby5716 wallaby5716 added the bug Something isn't working label Dec 20, 2020
@melek melek added this to To do in Next Version via automation Jul 29, 2021
@BlakeBi
Copy link

BlakeBi commented Jul 31, 2021

For anyone looking for a solution.

Line 297 of the Create Action macro under the GM panel is/Line 303 of the Create Action macro under the Campaign Panel:
[if(vAtkProficiency): vAtkProficiency = " + Proficiency"]

Can fix it if you change it to:
[if(vAtkProficiency): vAtkProficiency = " + Proficiency"; vAtkProficiency = ""]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Next Version
  
To do
Development

No branches or pull requests

3 participants