Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with button overflow in Maptool 1.12.0, 1.12.1 #37

Open
mal-w opened this issue Sep 30, 2022 · 0 comments
Open

Issue with button overflow in Maptool 1.12.0, 1.12.1 #37

mal-w opened this issue Sep 30, 2022 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@mal-w
Copy link

mal-w commented Sep 30, 2022

Describe the bug
This was originally posted in Discord

Hi @melek, I was just noticing in the 1.12.X (I'm specifically running 1.12.1), the campaign buttons for the campaign buttons render a little funny. In my first screenshot you can see how the 1dX all wrap, and the Concentrat. button wraps as well.

I'm not sure if this is the root issue, but the Min Width is set to 10px. (see second screenshot)

Removing that value seems to fix it since it auto shrinks to fit the contents (third screenshot, specifically the d4 button is fixed)...

If the goal was to make them all consistently sized then this might not be a perfect solution since auto-sizing would make all the buttons different sizes.. I would have suggested setting the Min Width using units of em... so like 4em would make sure there is no overflow for all die rolls and the buttons would be the same size... However setting Min Width using units of em doesn't do anything.

I can help maybe? I don't mind going through the 2.2.1 version of your campaign framework and updating this stuff to remove the Min Width setting, if that's what you think is best.. For the em stuff not working in the Min Width setting I'm not so sure what the right thing to do is.. maybe open an issue or mention it in #general_support ?

To Reproduce
Steps to reproduce the behavior:

  1. Open Version 2.2.1/Meleks Simple 5e v2.2.1.cmpgn in Maptool version 1.12.0 or 1.12.1.

Expected behavior

  1. For sure there shouldn't be wrapping on buttons.
  2. Optionally (maybe very important depending on your point of view) the buttons of the same type should be the same size.

Screenshots
image
image
image

Desktop (please complete the following information):

  • OS & Version: Ubuntu 20.04
  • MapTool Version: 1.12.1
  • MapTool Install type: Source install of 1.12.1 (i.e. running it using gradle run).

Additional context
Used to edit the macros:
https://discord.com/channels/296230822262865920/951780566653632532/1014776545321156648 bulk edit macro props

@mal-w mal-w added the bug Something isn't working label Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants