Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for react-router navigation #148

Open
luciob opened this issue Aug 26, 2020 · 0 comments
Open

Add support for react-router navigation #148

luciob opened this issue Aug 26, 2020 · 0 comments
Labels
question Research work required
Projects

Comments

@luciob
Copy link
Member

luciob commented Aug 26, 2020

All clickable elements like (Button, IconButton and so on..) must have support for react-router-dom navigation.
Currently to perform navigation in utilizing projects the user is forced to use the onClick callback passing the history.push() action which is not ideal.

The desired solution would be using the to property and pass to the native MUI component a RouterLink or a Link from the react-router-dom library.
This task requires a bit of understanding on how to handle react-router-dom library inside Mosaic, whether to treat it like a dependency or as a peerDependency.

@luciob luciob added enhancement New feature or request question Research work required labels Aug 26, 2020
@luciob luciob self-assigned this Aug 26, 2020
@luciob luciob added this to To do in Mosaic via automation Aug 26, 2020
@luciob luciob removed the enhancement New feature or request label May 3, 2023
@luciob luciob removed their assignment May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Research work required
Projects
No open projects
Mosaic
  
To do
Development

No branches or pull requests

1 participant