Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modal] Review and fix callbacks #99

Open
luciob opened this issue Apr 22, 2020 · 0 comments
Open

[Modal] Review and fix callbacks #99

luciob opened this issue Apr 22, 2020 · 0 comments
Labels
enhancement New feature or request
Projects
Mosaic

Comments

@luciob
Copy link
Member

luciob commented Apr 22, 2020 •
edited

Modal callbacks declaration isn't straightforward.
Review onClose and confirm/cancel callbacks as they are executed in a strange manner.

Also review from properties name and improving the docs in order to have a clearer result.
@luciob luciob added documentation Improvements or additions to documentation enhancement New feature or request labels Apr 22, 2020
@luciob luciob added this to To do in Mosaic via automation Apr 22, 2020
@luciob luciob changed the title Review declaration of Modal callbacks Review and fix Modal callbacks Apr 24, 2020
@luciob luciob added high Issue with high priority enhancement New feature or request and removed enhancement New feature or request labels Apr 24, 2020
@luciob luciob changed the title Review and fix Modal callbacks [Modal] Review and fix callbacks May 3, 2023
@luciob luciob removed documentation Improvements or additions to documentation high Issue with high priority labels May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
No open projects
Mosaic
  
To do
Milestone
No milestone
Development

No branches or pull requests
1 participant
@luciob