Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Causative not detected for verbs that end in す #142

Open
melink14 opened this issue Mar 7, 2018 · 3 comments
Open

Causative not detected for verbs that end in す #142

melink14 opened this issue Mar 7, 2018 · 3 comments

Comments

@melink14
Copy link
Owner

melink14 commented Mar 7, 2018

This problem occurs with verbs like 話す not being detected when in their causative forms such as 話させる this isn't the verb I tried it on either. I also tried it with the verb 飛ばす>飛ばさせる and it still doesn't detect it. It also detects passive す ending verbs as causative or passive as well.

@melink14 melink14 added bug help wanted 2018 triaged survived the 2018 fresh start labels Mar 7, 2018
@melink14 melink14 removed the 2018 triaged survived the 2018 fresh start label Aug 28, 2020
@melink14 melink14 removed the triaged label Jul 15, 2022
@tora-pan
Copy link
Contributor

tora-pan commented Mar 19, 2023

I can try to look into this one.

My guess is that it needs to be added to the deinflect.dat

It currently doesn't include an entry matching this case. I think something like this would need to be added:
させる す ### #

However, I'm not currently sure what these numbers represent exactly.

しましょう	す	640	2
しましょう	する	4224	2

I think the final number is the category like volitional or passive so in this case, it would be the causative form of a transitive verb.

Another test with 負かす:
Screenshot 2023-03-19 at 7 18 16 AM
Screenshot 2023-03-19 at 7 17 53 AM

@melink14
Copy link
Owner Author

You can read a break down of how the logic works here:
#988

For this and the rest of the deinflection labled issues; I've been waiting on fixing #257 to make it easier to update and understand but we can still fix smaller things as we need to.

I also can no longer reproduce the logic I mentioned in OP about sometimes it deinflecting passive conjugations as 'passive or causitive' so maybe there are no edge cases here.

@melink14
Copy link
Owner Author

whoops, I was checking potential forms not passive. Realized after looking at the dat file.

話される says it is a passive or causitive infelction of 話す and I think we should be confident about why that was put in. I think I looked briefly but didn't record any findings here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants