feat(dict): Whitelist Kanji Learner's Dictionary 2nd Edition

[tora-pan]

Whitelist Kanji Learner's Dictionary 2nd Edition.

Add required info to the kanjiInfo and kanjiInfoLabelList in their respective files.

Needs update to entries in kanji.dat file to include KLD 2nd Edition info.

Fixes #1363

[melink14]

Looks good to me, though I realize now I don't have any visual tests of the options page so I don't really know how this shows up...

Did you test manually?

For submission I think we should wait until after the monday regular update and then update the dictionary updating util to populate the DL reference and then submit with the new kanji dat file only.

[codecov]

Codecov Report

Merging #1448 (3e92667) into main (82630c0) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1448      +/-   ##
==========================================
+ Coverage   79.62%   79.67%   +0.04%     
==========================================
  Files           7        7              
  Lines        3004     3011       +7     
  Branches      189      189              
==========================================
+ Hits         2392     2399       +7     
  Misses        607      607              
  Partials        5        5              

Impacted Files	Coverage Δ
extension/configuration.ts	86.45% <100.00%> (+0.74%)	⬆️
extension/data.ts	82.36% <100.00%> (+0.03%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[melink14]

Can you run the script and upload only the kanji data files as well?

We don't want the changes casued by this PR to show up in an unrelated PR later since that will make tracing changes harder in the past.

You'll find most of the effort we take in constructing commits and PRs is all to make understanding the logic and reasoning of the codebase easier for our future selves. :)

[tora-pan]

I think everything went well.

ran npm run update-db and this was the output.

Fetching word dictionary...
Parsing dictionary created: 2023-03-13
Writing index...
Fetching names dictionary...
Parsing dictionary created: 2023-03-13
Writing index...
Fetching kanji dictionaries...
Parsing KANJIDIC dictionary from 2023-03-13
Parsing KANJD212 dictionary from 2023-03-13
Done.

Did A quick scan over the file and it looks like it worked correctly. May rows contain the DL#### number now.

Will push changes now.

[melink14]

Two things:

1. To re-iterate from my last question: did you test this manually selecting and deselecting the new index from options. Since there are no tests for options, we should do a bit of testing first.

2. I noticed this still said it was waiting on changes to be made but you can't resolve the top level review comment like this. I'd say once you're 'waiting' you should click the 're-request review' button to passit back to me.

[tora-pan]

Sorry about that.

Yes it has been tested.

[melink14]

More than the kanji view (which has automated testing) I was curious about the options page which lacks visual tests. Just to double-check, I assume it appears and works there too? 2023年3月20日(月) 9:40 Travis Pandos ***@***.***>:

…

Sorry about that. Yes it has been tested. [image: Screenshot 2023-03-19 at 5 34 35 PM] <https://user-images.githubusercontent.com/81494248/226221338-e7f72b53-291c-4be6-b9db-cfc660d098d4.png> — Reply to this email directly, view it on GitHub <#1448 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAI7HZRZ3WK7J6IR4LXR5ATW46ROZANCNFSM6AAAAAAVYCVJWQ> . You are receiving this because you commented.Message ID: ***@***.***>

[tora-pan]

yep, I tested by toggling it on and off.

[tora-pan]

I'll send more screenshots or a mini video later 👍

[melink14]

🎉 This PR is included in version 2.5.0 🎉

The release is available on:

• Chrome Web Store
• GitHub release

Your semantic-release bot 📦🚀

[melink14]

Just as a note to future readers: I meant to edit the PR title before merge to something a bit more specific but forgot. Luckily it was already pretty good!

[melink14]

@all-contributors Add @tora-pan for code.

[allcontributors]

@melink14

I've put up a pull request to add @tora-pan! 🎉