Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Prevent inheritable styles from affecting rikaikun #958

Merged
merged 2 commits into from
Apr 5, 2022

Conversation

melink14
Copy link
Owner

@melink14 melink14 commented Apr 5, 2022

Uses all: initial instead of all: revert since revert defaults to
inheriting if possible.

Fixes #956

melink14 and others added 2 commits April 5, 2022 14:05
Uses `all: initial` instead of `all: revert` since revert defaults to
inheriting if possible.

Fixes #956
@melink14 melink14 closed this Apr 5, 2022
@melink14 melink14 reopened this Apr 5, 2022
@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Merging #958 (b9d5f04) into main (8f31bc2) will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #958      +/-   ##
==========================================
+ Coverage   79.65%   79.72%   +0.06%     
==========================================
  Files           7        7              
  Lines        3003     3003              
  Branches      171      171              
==========================================
+ Hits         2392     2394       +2     
+ Misses        610      608       -2     
  Partials        1        1              
Impacted Files Coverage Δ
extension/rikaicontent.ts 76.31% <0.00%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f31bc2...b9d5f04. Read the comment docs.

@melink14 melink14 merged commit 6b05b00 into main Apr 5, 2022
@melink14 melink14 deleted the melink14/noinherit branch April 5, 2022 05:19
melink14 pushed a commit that referenced this pull request Apr 5, 2022
### [2.3.1](v2.3.0...v2.3.1) (2022-04-05)

### Bug Fixes

* **ui:** Prevent inheritable styles from affecting rikaikun ([#958](#958)) ([6b05b00](6b05b00)), closes [#956](#956)
@melink14
Copy link
Owner Author

melink14 commented Apr 5, 2022

🎉 This PR is included in version 2.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

definitions centered on Weblio Jisho
1 participant