Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the name of the included build from the include name #11

Closed
Vampire opened this issue Nov 25, 2021 · 2 comments
Closed

Set the name of the included build from the include name #11

Vampire opened this issue Nov 25, 2021 · 2 comments
Milestone

Comments

@Vampire
Copy link
Contributor

Vampire commented Nov 25, 2021

As discussed on Slack, please make it so that

gitRepositories {
    include("fonts_v3_0") {
        uri.set("git@git.company.com:fonts")
        tag.set("v3.0")
        includedBuild {
            name = "fonts_v3_0"
        }
    }
}

could simply be

gitRepositories {
    include("fonts_v3_0") {
        uri.set("git@git.company.com:fonts")
        tag.set("v3.0")
    }
}
@melix
Copy link
Owner

melix commented Nov 25, 2021

I am actually a bit confused. The checked out directory should be named after the include name. So it should be fonts_v3_0 already.

@melix melix closed this as completed in 0ec3188 Nov 25, 2021
@melix melix added this to the 0.1.3 milestone Nov 26, 2021
@Vampire
Copy link
Contributor Author

Vampire commented Nov 26, 2021

Now I'm confused too.
I removed the name = lines at the included builds seem to be named like I want it.
But for some reason I had to set the name explicitly. :-/
Sorry for the noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants