-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Current make watch
target fails to find air
even after successful installation
#74
Comments
$GOPATH itself is not deprecated, what this was doing was fine. https://blog.smantic.dev/posts/gopath-is-not-deprecated/ What is deprecated is using $GOPATH as the workspace for go projects. This was typically where you developed go codebases before go modules.
This assumes that the user has added $GOBIN ($GOPATH/bin) to the user's path. This isnt a thing that happens automatically. The previous implementation did not assume that the user had $GOBIN in their path. |
Yess @smantic, the description of the issue is indeed wrong, thanks for pointing it out. My experience (and from issue #111 apparently) was that the previous implementation ran on every run of I'm currious to see if people will have issues with the new implementation as you said that. I will take look into what could solution could be taken to make this as more generalized (work on more machines) as possible. |
Description
When running
make watch
after successfully installingair
, the Makefile still prompts "air is not installed. Do you want to install it now? (y/n)". This happens even thoughair
has been installed and is available in the PATH.It seems like the GOPATH has been deprecated in Go 1.16 and should not be relied on.
Environment
Additional Information
Here is the
watch
target in the Makefile:The text was updated successfully, but these errors were encountered: