Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pack-osrs-dark] Distinguish selected and unread chat tabs (iawhd) #49

Open
cannonpalms opened this issue Aug 3, 2020 · 6 comments
Open

Comments

@cannonpalms
Copy link

Currently, the colors used for the currently selected chat tab and chat tabs with unread messages are extremely similar. The currently selected chat tab is ever so slightly darker than unread chat tabs, but this is indiscernible at a glance.

image

I suggest trying the slightly brighter red that is currently being used for selected interface tabs (e.g. inventory, equipment, friends list, etc.). If that slightly brighter red still is not sufficiently distinguishable, perhaps either the selected chat tab or unread message tabs can go to a darker gray (i.e. the dark gray used for unselected interface tabs [inventory, etc.]).

@cannonpalms
Copy link
Author

cannonpalms commented Aug 3, 2020

Update: I actually quite like the solution Noedel uses in his OSRS-Grey theme as well. It makes it clear which chat tab is selected via a concave / depressed look. More food for thought.

image

@WlcxDev
Copy link

WlcxDev commented Aug 4, 2020

Hey @cannonpalms,

It's not something I've noticed before tbh (I leave my chat on ALL), but I agree this could be better.

I'll take a look at this now and get an update pushed as my pack is slightly behind anyway.

@noelvissers
Copy link

noelvissers commented Aug 7, 2020

The way I did it (and the way it is in the vanilla skin) is to rotate the button 180 degrees. So if you want an easy solution that looks familiar to the original skins you could try that.

Edit:
I'd also like to add the wiki button to this request (can't see difference between static and pressed). You can take that from pack-osrs-dark-light if you want.

@cannonpalms
Copy link
Author

cannonpalms commented Aug 19, 2020

@iawhd Any progress on this? If you haven't already completed this on your end, I suggest using Noedel's chatbox/button_selected.png. I'm not familiar enough with resource packs to be able to tell you if you would also need to pull in Noedel's button_selected_hovered.png, etc.; I defer to your knowledge on this bit.

Noedel's grey (dark-light) theme is, of course, MIT licensed. If you decide to use his button, you merely have to add him to the license in your branch like so:

The MIT License

Copyright (c) 2020 Jake Wilcox
Portions Copyright (c) 2020 Noël Vissers

Permission is hereby granted...

@noelvissers RE: your edit, I'd recommend opening a separate issue for discussion of other change requests.

@cannonpalms
Copy link
Author

cannonpalms commented Aug 19, 2020

/cc @noelvissers

@noelvissers
Copy link

@cannonpalms I made a new issue for the wiki button: #52. Thanks for letting me know ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants