-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using ScrollFollow results in maximum updates exceeded error #36
Comments
can you put together a StackBlitz example showing the issue? |
@melloware I figured out that the issue happens when the outer div containing the doesn't have an height, the issue occurs. When you set an height on the outer div, the issue is gone |
@kevinvugts can you post your sample code that works? I would like to update the README.MD. The current docs import React from "react";
import { render } from "react-dom";
import { LazyLog, ScrollFollow } from "@melloware/react-logviewer";
render(
<ScrollFollow
startFollowing={true}
render={({ follow, onScroll }) => (
<LazyLog url="http://example.log" stream follow={follow} onScroll={onScroll} />
)}
/>,
document.getElementById("root"),
); |
GOodmorning melloware, Just simply wrap the with a div containing a fixed height
|
Thanks docs updated! https://github.com/melloware/react-logviewer/blob/main/README.md |
Hi, when using the auto scroll functionality it currently results in an infinite loop.
The text was updated successfully, but these errors were encountered: