Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] increase number of samples #56

Closed
rethink-studios opened this issue Aug 5, 2023 · 3 comments
Closed

[feat] increase number of samples #56

rethink-studios opened this issue Aug 5, 2023 · 3 comments
Labels
type: 🤚 feature request New feature or request

Comments

@rethink-studios
Copy link

Describe the problem

Your implementation is very fast, but I wonder if image quality suffers.
Take a look at this video:

https://www.dropbox.com/s/xdiwyfmv29szo6h/MTB_LowRes_Output.mp4?dl=0

Describe the solution you'd like

I'd love to increase the number of samples, so that images are crisp and clean

Alternatives considered

Is it possible to add a parameter that increases the number of samples?
Or, am I off target as to how the script works?

Additional context

No response

@rethink-studios rethink-studios added the type: 🤚 feature request New feature or request label Aug 5, 2023
@melMass
Copy link
Owner

melMass commented Aug 5, 2023

The thing I discovered while adapting the implementation to Comfy is that inswapper is done at 128px... So the direct output looks bad... That's why there is face restore nodes, they are mainly meant to work with faceswap I don't really use them otherwise, you can check and example of the chain it's the first example here: https://github.com/melMass/comfy_mtb/wiki/Examples

georges

There is still a strange border as explained here: #40 (comment)

@melMass
Copy link
Owner

melMass commented Aug 7, 2023

I'm going to close this issue but feel free to comment if still not resolved, however note that for face restoration these nodes might give better results for face restoration: https://civitai.com/models/24690/comfyui-facerestore-node

@melMass melMass closed this as completed Aug 7, 2023
@rethink-studios
Copy link
Author

Apologies!
I've been playing with the script all weekend, and YES I'm using the upscaler.
Works well, minus artifacts at the borders:

image

I know this has been discussed in another thread, but is it possible to add a crop factor parameter, much like in FaceDetailer, to clean up the edges for better image integration?

At this point, to remove, I'll re-encode the image and add a touch of denoise, but that process pushes the image too far away from the desired look:

image

Thoughts?

Getting close!!
Thanks for the hard work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: 🤚 feature request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants