Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Not able to install Models, Install of mtb in ComfyUI still shows missing nodes #71

Closed
Tikishark777 opened this issue Aug 21, 2023 · 17 comments
Labels
🎭 Face nodes Related to the faceswap or facerestore nodes type: 🐛 bug Something isn't working

Comments

@Tikishark777
Copy link

Describe the bug

I'm trying to use the mtb nodes. I've installed through the manager, but ComfyUI still shows the following nodes missing.

When loading the graph, the following node types were not found:
Face Swap (mtb)
Load Face Enhance Model (mtb)
Load Face Analysis Model (mtb)
Load Face Swap Model (mtb)
Restore Face (mtb)
Nodes that have failed to load will show as red on the graph

I've tried uninstalling and reinstalling mtb, but received the same error each time.

I thought perhaps that it was because the models were missing so I tried the python download_models.py script in the script folder, but I received the following error message:

ModuleNotFoundError: No module named 'requests'

I also tried to install the dependencies, but received this error when running python get_deps.py

\ComfyUI\custom_nodes\comfy_mtb\scripts\get_deps.py", line 5, in
from rich.console import Console
ModuleNotFoundError: No module named 'rich'

Reproduction

No response

Expected behavior

No response

Platform and versions

Windows

Console output

[comfy_mtb] | INFO -> Some nodes failed to load:
        Failed to import module faceenhance because ModuleNotFoundError: No module named 'gfpgan'
        Failed to import module faceswap because ModuleNotFoundError: No module named 'insightface'
        Failed to import module image_interpolation because ModuleNotFoundError: No module named 'frame_interpolation.eval'

Check that you properly installed the dependencies.
If you think this is a bug, please report it on the github page (https://github.com/melMass/comfy_mtb/issues)

Additional context

No response

@Tikishark777 Tikishark777 added status: 🧹 needs triage This issue needs to triage, applied to new issues type: 🐛 bug Something isn't working labels Aug 21, 2023
@s-marcelle
Copy link

I've been having the same issue. I hope that some solution is eventually attained.

@melMass
Copy link
Owner

melMass commented Aug 23, 2023

@s-marcelle Also using the manager?
Because all of the logs from the OPs report suggest that not, gfpgan and frame_interpolation are shipped with mtb (in the extern folder), you must clone the repository with submodules (comfy manager does it all for you)

@s-marcelle
Copy link

Yes I installed via the manager as instructed....

And I am also experiencing the same as the person who raised the issue.

@melMass
Copy link
Owner

melMass commented Aug 23, 2023

And I am also experiencing the same as the person who raised the issue.

The OP has multiple issues:

  • none of the script they run manually should be (get_deps, model_downloads), they are there useful for people who can simply read them, but not mentioned in the base instructions for this reason. (I'm pretty sure request comes with comfy portable btw). The models can be downloaded from the comfy manager directly.
  • The project gets downloaded without the submodules (gfpgan and frame_interpolation), this is apparently a thing on very old git, I just learned that from DataIt after this issue was posted on the element board.

That's why I usually suggest openining dedicated issues with your own log unless it's not a generic issue but "not able to install" is too broad and it's unclear what you mean by "same" here

@s-marcelle
Copy link

s-marcelle commented Aug 23, 2023

I have all the models loaded.. I will run from the start and I will share the issues displayed in the cmd window

@Tikishark777
Copy link
Author

I'm not sure if a solution has been found? You never responded to my request. Would you clarify what you want me to do to install this extension? I initially used control manager and installed Mtb. I looked at the download_models script, but I'm not sure if you're asking me to manually download each one? You say that the control manager automatically downloads all the models, but that's not happening for me. Help would be appreciated.

@melMass
Copy link
Owner

melMass commented Aug 25, 2023

You are having multiple unrelated things happening, I did address your points in my answers...

Here you can click Install models and look for the ones you need, I plan to add a new UI in /mtb's endpoint for those who can't either run my model download script or Comfy Manager's download ui.
image

Just check my previous answers but something went wrong during your install and it did not pull the submodules (gfpgan, frame_interpolation)

For insightface you can try to manually running this, but the install script handle much more:

pip install https://github.com/melMass/comfy_mtb/releases/download/v0.1.3/insightface-0.7.3-cp310-cp310-win_amd64.whl

@justanotherbug

This comment was marked as off-topic.

@melMass
Copy link
Owner

melMass commented Aug 25, 2023

I introduced this issue when trying to handle space in path (#73)
I just fixed it

@melMass melMass changed the title Not able to install Models, Install of mtb in ComfyUI still shows missing nodes[bug] [bug] Not able to install Models, Install of mtb in ComfyUI still shows missing nodes Aug 26, 2023
@melMass melMass removed the status: 🧹 needs triage This issue needs to triage, applied to new issues label Aug 28, 2023
@melMass
Copy link
Owner

melMass commented Aug 28, 2023

Did it work :) ?

@Tikishark777
Copy link
Author

No, unfortunately I've given up hope for now. I've tried clean installs, manually installing each component or/and using the custom manager. I'm going to try again in a few weeks in hopes that an updated version may help. Ty for trying to fix it.

@melMass
Copy link
Owner

melMass commented Aug 29, 2023

Understandable! I will gather the recent feedbacks to try and fix some of these, I linked other projects for the faceswap and facerestore nodes in the README since most recent errors seems related to that, i think my install script is doing something that trip Comfy Manager

@cn112cn
Copy link

cn112cn commented Sep 3, 2023

Anyone got a solution for this? I tried almost a dozen clean install, always the same error.

@melMass
Copy link
Owner

melMass commented Sep 3, 2023

@cn112cn Please open a dedicated issue, both points from the OP's issue have been addressed in #71 (comment) and #71 (comment). The unrelated issue reported by that has also been fixed since.
Since I still can't mind-read don't hesitate to join some log and informations about you system / Comfy install it saves time for spotting issues

@jetzwow
Copy link

jetzwow commented Sep 4, 2023

So i was able to fix this issue on my install by uninstalling the modules that are not found and reinstalling them with the install script.

My error was:
Failed to import module image_interpolation because ModuleNotFoundError: No module named 'insightface'

So i went to custom_nodes\comfy_mtb, open PowerShell

Uninstall insightface
enter path\to\python_embeded\python.exe -m pip uninstall insightface

Reinstall using install.py
enter path\to\python_embeded\python.exe install.py

I did this for every ModuleNotFoundError Comfy threw out and was able to fix and load all mtb modules.

I do have a local Python as well as the embedded. The removed modules were installed under my local and now reinstalled under the embedded. So could it be some kind of PATH issue?

@LubuLubu2
Copy link

LubuLubu2 commented Sep 7, 2023

Mine was working up until 6 7 hours ago. Manager updated itself and MiT and boom, there is no faceswap anymore and all the nods shows missing.

Update: installed https://github.com/GeLi1989/GK-beifen-ComfyUI_roop or Roop_Nods_for_comfyui in the manager and mit nodes are back.

@melMass melMass added the 🎭 Face nodes Related to the faceswap or facerestore nodes label Sep 13, 2023
@melMass melMass added this to the Release of v0.2.0 milestone Sep 25, 2023
@melMass
Copy link
Owner

melMass commented Oct 10, 2023

Hi,

The problematic nodes are removed in the next version as comfy portable is now on python 11, more precisely they are optional, you can learn more about it in the readme where I link to alternatives: https://github.com/melMass/comfy_mtb#optional-nodes

@melMass melMass closed this as completed Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎭 Face nodes Related to the faceswap or facerestore nodes type: 🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

7 participants