Infinite read loop when server disconnects in PubSub mode

[mrunonen]

Connected client that is in PubSub mode seems to go into an infinite loop when the server side disconnects. Looking inside the module, it is this

while (__try_read_sock($sock))

in wait_for_messages() that never returns.

Is this known behaviour or a defect?

[melo]

It's not a known behaviour.

Can you provide:

• the operating system: we had problems with windows before;
• which Redis.pm version are you using.

I'll try to reproduce it.

[mrunonen]

Hi melo,

Thanks, very swift :)

Red Hat Enterprise Linux Server release 5.5 (Tikanga) / Redis.pm 1.958 / perl 5, version 14, subversion 1 (v5.14.1)

[melo]

Ok, pretty sane environment :)

Probably a bug. I'll check it out.

[melo]

Please test master if you can... It should be fixed. I'm going to wait for Travis build 49 (build 48 only included the failing test case) to see if everything is kosher and then release 1.959.

[mrunonen]

Just tried master, works perfectly. Thank you very much & keep up the good work!

[melo]

Cool, glad to know.

Will release 1.959 after lunch, Travis should be done by then...

(@Ovid: this might fix #32, but will not include #33, I need a bit more time to merge #33, master drifted away from you base point; I'll do it tonight).