bug(DevTools): break on startup has no effect

[axel7083]

Bug

When selecting break on startup the game does not break at startup

no-break-startup.mp4

Reproduce

Tested with master 31a7f53

• (1) git checkout
• (2) follow build instruction standalone windows
• (3) start emulator
• (4) change settings for AMR9
• (5) restart the emulator
• (6) boot a game
• (7) no break

[axel7083]

@PoroCYon do you have some ideas ?

[PoroCYon]

sorry, don't really have time to look into it

could you try bisecting between 3ab752b and 31a7f53 to see which commit introduced the bug? there's been some refactoring going on so it could be something like that

[RSDuck]

from a glance it looks like GDB args are only passed in when the NDS object is created (

melonDS/src/frontend/qt_sdl/EmuThread.cpp

Line 145 in 10798c3

Config::GdbEnabled ? std::make_optional(gdbargs) : std::nullopt,

). They should be updated here as well

melonDS/src/frontend/qt_sdl/EmuThread.cpp

Line 295 in 10798c3

NDS->SPU.SetDegrade10Bit(static_cast<AudioBitDepth>(Config::AudioBitDepth));

Though then the setting should work under the condition that the setting was enabled during the construction of the NDS object (i.e. program startup or when switching between DS or DSi mode).

[PoroCYon]

Though then the setting should work under the condition that the setting was enabled during the construction of the NDS object (i.e. program startup or when switching between DS or DSi mode).

Yeah, this was also a limitation from before the refactoring.