Add "nproc" support to getrlimit/setrlimit (for supported OSes) #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the merge and quick release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This picks up on @fbrusch's pull request from #22. It adds the
nprocsupport, but is#ifdefed like you suggested, and I updated the documentation in the README.I also added tests that I believe should work across platforms to ensure that it's supported on the expected platforms but still raises errors on unsupported platforms. I don't have access to a Solaris or Windows box to totally verify these tests across platforms, but from what I gather it's only supported on Linux and BSDs (and they pass locally on a Linux and OS X box), so I'm hoping the test logic for platform support is correct.