Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case of package names is not consistent. #138

Closed
milkypostman opened this issue May 29, 2012 · 5 comments
Closed

Case of package names is not consistent. #138

milkypostman opened this issue May 29, 2012 · 5 comments

Comments

@milkypostman
Copy link
Member

I noticed the following error,

"Removing archive: (inliner . [(20120520) nil insert Tag for inline image of R graphics [source: github] single])"

"Removing archive: (helm-r . [(20120523) ((helm (20120517)) (ess (20120509))) helm-sources and some utilities for GNU R. [source: github] single])"

And the problem is that package-build-alist is setup to use package names out of the "recipes" directory which allows for capitalization of the package name. However, in pb/merge-package-info the name is getting downcased. And thus when the package gets added to pacage-build-archive-alist the car of each package is no longer consistent. I have removed the downcase in 6c46737

Please close this if it is OK, otherwise let us discuss why that is in there.

@purcell
Copy link
Member

purcell commented May 29, 2012

We should probably check that the car exactly matches the recipe filename.

@milkypostman
Copy link
Member Author

yeah, but we should really just remove the car and get that from the filename?

@milkypostman
Copy link
Member Author

excuse my hasty reply, i believe we should trust the car before the filename? I can write a small snippet to fix this and "verify" the recipes. But why the downcasing? Was there an original reason or just seemed right?

@purcell
Copy link
Member

purcell commented May 29, 2012

I'm 99% certain I didn't write any new code which downcased.

It would kinda make sense to remove the car from the recipe data, though that idea feels a bit strange.

@milkypostman
Copy link
Member Author

it was probably something i did a long time ago. no worries. it's gone now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants