New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require passing CI build before building a recipe? #4863
Comments
I should say that I'm willing to write some code to implement this. I just want to know if it's something you would be interested in first. |
We don't really have any mechanism for nicely handling failure of builds, to be honest, so this is potentially a can of worms from a purely technical point of view. And we don't have any mechanism for authors to determine that their package has not built, and why. But in any case, I would prefer if MELPA simply contains a package of the latest master code, whatever its state, even if that very occasionally means "broken", for some value of that term. MELPA Stable allows for packages that have been verified in some way. |
You mean MELPA doesn't have a way to reject the latest master and keep using whatever version it had previously? |
Well, if the build of a package fails, the old version isn't replaced. But the build failures aren't surfaced in any helpful way, and the only failures we currently expect are catastrophic ones, e.g. upstream repo. disappearing, or malformatted recipe / package descriptor file. There's otherwise no concept of verifying that a package is "good". |
Ok, fair enough. I guess this would require significant changes to the inner workings of MELPA's build process, then. |
In the longer term I'd like to run |
Ok, sounds good to me. |
I've just set up Travis CI for my ido-completing-read+ package (here), and I was thinking that it would be nice if MELPA could check the CI build status for the master branch and avoid updating the package if the CI status is not passing. Obviously this would not be something to enable for all packages, so I'm imagining adding an option to a package recipe to tell MELPA where to find the CI status for that package. Do you think this is feasible? I know that for my package, if any of the tests fail, I definitely want to prevent that version from getting to MELPA until I fix it.
The text was updated successfully, but these errors were encountered: