Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Char.isCntrl should return false for non-ASCII characters #162

Closed
minoki opened this issue Jan 20, 2024 · 0 comments
Closed

Char.isCntrl should return false for non-ASCII characters #162

minoki opened this issue Jan 20, 2024 · 0 comments

Comments

@minoki
Copy link

minoki commented Jan 20, 2024

https://smlfamily.github.io/Basis/char.html says Char.isCntrl c is equivalent to isAscii c andalso not (isPrint c), so the condition

mlkit/basis/Char.sml

Line 63 in a312f16

fun isCntrl c = c < #" " orelse c >= #"\127"

should be changed to return false for non-ASCII characters.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@minoki