Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no auto update comment for overriding #105

Open
pnadolny13 opened this issue Sep 5, 2023 · 1 comment
Open

Add no auto update comment for overriding #105

pnadolny13 opened this issue Sep 5, 2023 · 1 comment

Comments

@pnadolny13
Copy link
Collaborator

Sometimes it easier to make changes to the hub definitions manually vs fixing the underlying tap. In this case sometimes the hub update code reverts the manual changes. We should have a way to tell the code to not update that attribute even if it has changes.

Similar to a # noqa comment for linting we could add a comment to the yaml to flag manual overrides.

@pnadolny13 pnadolny13 changed the title Add no auto update comment Add no auto update comment for overriding Sep 5, 2023
@pnadolny13
Copy link
Collaborator Author

Ruamel supports preserving comments but we clobber them when we retrieve the settings from the about output. We should instead iterate the output and update only settings that don't have the ignore comment included for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant