Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meltano remove lock file bug #5979

Closed
tayloramurphy opened this issue Jun 2, 2022 · 1 comment · Fixed by #5980
Closed

Meltano remove lock file bug #5979

tayloramurphy opened this issue Jun 2, 2022 · 1 comment · Fixed by #5980
Assignees
Labels
kind/Bug Something isn't working valuestream/Meltano

Comments

@tayloramurphy
Copy link
Collaborator

From #5977 I was removing an installed plugin and got this on the command line:

❯ meltano remove orchestrator airflow
2022-06-02T15:20:50.385299Z [info     ] Environment 'dev' is active

Removing orchestrator 'airflow'...

Reset orchestrator 'airflow' plugin settings in the system database
Removed orchestrator 'airflow' from meltano.yml
Removed orchestrator 'airflow' from .meltano/orchestrators
Could not find orchestrator 'airflow' in /Users/taylormurphy/Documents/Projects/dev/meltano/addfromhub/plugins/orchestrators/airflow--original.lock to remove

In my plugins/ folder I still have:

plugins
  files/
     airflow--meltano.lock
  orchestrators/
     airflow--apache.lock

@edgarrmondragon cc @aaronsteers

@edgarrmondragon
Copy link
Collaborator

edgarrmondragon commented Jun 2, 2022

@tayloramurphy Ah, the quirks of putting the variant in the filename. meltano remove doesn't take the variant name into account and thus tries to remove a plugin with the fallback original variant.

This wasn't scoped in the original lockfile issue so I didn't dive too deep, but I think I have a fix that relies on the plugin still being present in meltano.yml, otherwise we might need to look for lockfiles of any variant (e.g. orchestrators/airflow*.lock) and remove those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/Bug Something isn't working valuestream/Meltano
Projects
None yet
2 participants