Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Coverage on Windows doesn't accurately count lines #6325

Closed
visch opened this issue Jun 30, 2022 · 1 comment
Closed

Code Coverage on Windows doesn't accurately count lines #6325

visch opened this issue Jun 30, 2022 · 1 comment

Comments

@visch
Copy link
Collaborator

visch commented Jun 30, 2022

https://github.com/meltano/meltano/pull/6208/files

All of the PR comments from code coverage are from sections of the code that are only executed when you're on Windows. This causes the PRs to mistakenly show that the code has less test coverage than actuality
@visch visch changed the title Code Coverage does run on Windows Platform Code Coverage on Windows Jun 30, 2022
@visch visch changed the title Code Coverage on Windows Code Coverage on Windows doesn't work Jun 30, 2022
@visch visch changed the title Code Coverage on Windows doesn't work Code Coverage on Windows doesn't accurately count lines Jun 30, 2022
@visch visch mentioned this issue Jul 1, 2022
Closed
@visch
Copy link
Collaborator Author

visch commented Jul 1, 2022

Closed in favor of #6330

@visch visch closed this as completed Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@visch