New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meltano lock fails on migrating to >2.0.0 when variant didnt previously exist #6360
Comments
@edgarrmondragon @pnadolny13 Alternatively, could we make the That's essentially to what Also:
I don't think we should recommend this: |
@DouweM yeah thats true - I dont know all the details of executable/namespace but what I was calling out was that I had some plugins defined that were previously custom but are now available on the hub so when I run a "lock --all" they get skipped. I think because their namespace/executable are present and its currently defined as a custom plugin. We'd want to encourage users to migrate from custom to "hub managed" for all of those, as long as theyre not still custom (like from a private repo or not listed on the hub). Wouldnt removing namespace/executable be the way to do that? I just want to make sure people are not accidentally making their installed plugins look like custom ones where they wouldnt get locked or benefit from upgrades on the hub. Maybe in this new migration guide section we can just make another note to reiterate that custom plugins dont get locked because they dont use the hub and that if you include keys like executable/namespace (are there others?) Meltano will treat it as a custom plugin and not lock it. Reiterating also that most plugins are available on the hub now so users should switch to those vs custom installations. Does that make sense? |
@DouweM I think for the short-term it makes sense to mainly update the docs as new users from 2.0 on will always have a variant for any new plugin. While I like the idea of making it smarter it'd be quicker to get an update to the docs listing the main plugins folks have to update. @edgarrmondragon would you be willing to make the docs PR as well? |
@pnadolny13 That makes sense, I wasn't thinking about the taps/targets that are now on the Hub but weren't previously. Your recommendation on what to document sounds good. @tayloramurphy Good point on doing the quickest thing. If we add "set an explicit variant" to the migration guide, we may not need the better log message as people shouldn't see it anymore, but if someone misses that step I think it'd still be confusing that everything works fine, except for |
@DouweM makes sense to me. Log messages are kind of bucketed under documentation in my head a bit too. Scope of the issue:
|
@edgarrmondragon - Do you have confidence in what would be needed on the docs side here, and then some helpful update to the error text that could point to the assist in the docs? |
@aaronsteers yes, I think we can either
The latter would make this a bug fix rather than a mere documentation task. It should be fairly safe AFAICT, but we can still emit warning. Wdyt? |
We should update the log message and add a section to the migration docs to help users get variants added for plugins that didnt have a variant previously. For example Airflow locking fails because a variant isnt set for all installations prior to 2.0.0. The error message isnt totally clear in saying this and users will need to manually update their meltano.yml.
Originally discussed in #6359 (comment)
cc @edgarrmondragon
The text was updated successfully, but these errors were encountered: