Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make default_environment a top-level setting #6582

Merged
merged 2 commits into from Aug 9, 2022

Conversation

WillDaSilva
Copy link
Member

Closes #6115

@WillDaSilva WillDaSilva self-assigned this Aug 8, 2022
@netlify
Copy link

netlify bot commented Aug 8, 2022

Deploy Preview for meltano canceled.

Name Link
🔨 Latest commit 049318c
🔍 Latest deploy log https://app.netlify.com/sites/meltano/deploys/62f12122e38085000921506a

@WillDaSilva
Copy link
Member Author

Draft until #6583 has been resolved.

@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #6582 (049318c) into main (fbadda1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #6582   +/-   ##
=======================================
  Coverage   96.57%   96.57%           
=======================================
  Files          96       96           
  Lines        8505     8505           
  Branches      405      405           
=======================================
  Hits         8214     8214           
  Misses        225      225           
  Partials       66       66           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@WillDaSilva WillDaSilva marked this pull request as ready for review August 8, 2022 16:01
Copy link
Collaborator

@edgarrmondragon edgarrmondragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@WillDaSilva WillDaSilva merged commit 25c0aed into main Aug 9, 2022
@WillDaSilva WillDaSilva deleted the default-env-setting branch August 9, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

default_environment can only be set in meltano.yml, not using meltano config meltano set
2 participants