Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add example meltano projects #6671

Merged
merged 13 commits into from Aug 31, 2022
Merged

docs: add example meltano projects #6671

merged 13 commits into from Aug 31, 2022

Conversation

sbalnojan
Copy link
Contributor

  • add example projects page to index (in tutorials section)
  • add multiple example projects (in three different categories)

@netlify
Copy link

netlify bot commented Aug 25, 2022

Deploy Preview for meltano ready!

Name Link
🔨 Latest commit e1d5792
🔍 Latest deploy log https://app.netlify.com/sites/meltano/deploys/630dc32cd4f1750008235006
😎 Deploy Preview https://deploy-preview-6671--meltano.netlify.app/tutorials/example-projects
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #6671 (e1d5792) into main (4115c4a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #6671   +/-   ##
=======================================
  Coverage   82.91%   82.91%           
=======================================
  Files         178      178           
  Lines       11360    11360           
  Branches     1553     1553           
=======================================
  Hits         9419     9419           
  Misses       1675     1675           
  Partials      266      266           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@tayloramurphy tayloramurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes requested - but this looks great!

docs/src/_tutorials/example-projects.md Outdated Show resolved Hide resolved
docs/src/_tutorials/example-projects.md Outdated Show resolved Hide resolved
docs/src/_tutorials/example-projects.md Outdated Show resolved Hide resolved
@afolson
Copy link
Contributor

afolson commented Aug 25, 2022

@sbalnojan This looks great! There are a few minor changes to make but otherwise it's good to go once those are fixed. 🎉

sbalnojan and others added 8 commits August 26, 2022 10:56
Co-authored-by: Taylor A. Murphy <taylor@meltano.com>
Co-authored-by: Taylor A. Murphy <taylor@meltano.com>
Co-authored-by: Taylor A. Murphy <taylor@meltano.com>
Co-authored-by: Taylor A. Murphy <taylor@meltano.com>
@sbalnojan sbalnojan dismissed tayloramurphy’s stale review August 30, 2022 08:00

I think I committed all changes you requested and messed something up!

Copy link
Collaborator

@tayloramurphy tayloramurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbalnojan it looks good to me! Not sure what got messed up if anything.

@sbalnojan sbalnojan merged commit 7318801 into main Aug 31, 2022
@sbalnojan sbalnojan deleted the 613-find-example-projects branch August 31, 2022 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants