fix: Prevent warnings/errors when running meltano config <plugin> test
#6676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReubenFrankel
requested review from
pandemicsyn and
edgarrmondragon
as code owners
馃懛 Deploy request for meltano pending review.Visit the deploys page to approve it
|
Codecov Report
@@ Coverage Diff @@
## main #6676 +/- ##
=======================================
Coverage 82.91% 82.91%
=======================================
Files 178 178
Lines 11360 11360
Branches 1553 1553
=======================================
Hits 9419 9419
Misses 1675 1675
Partials 266 266
馃摚 We鈥檙e building smart automated test selection to slash your CI/CD build times. Learn more |
|
Linter was complaining about docstrings in |
edgarrmondragon
approved these changes
Aug 30, 2022
|
@ReubenFrankel lgtm! thanks for taking the time to add docstrings and fix the type annotations. I'll request review from other folks in the team in case I missed anything. |
WillDaSilva
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6632 by waiting for subprocess to exit after terminating given a
RECORDmessage received, instead of immediately returning from the method. Includes some other minor related fixes, since I was in the area. 馃槃Before fix
Python 3.7
Python 3.9
After fix
Python 3.7
Python 3.9
Checklist