New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update custom extractor tutorial #6703
docs: update custom extractor tutorial #6703
Conversation
👷 Deploy request for meltano pending review.Visit the deploys page to approve it
|
Codecov Report
@@ Coverage Diff @@
## main #6703 +/- ##
==========================================
+ Coverage 88.68% 88.70% +0.01%
==========================================
Files 283 283
Lines 20401 20401
Branches 2010 2010
==========================================
+ Hits 18093 18096 +3
+ Misses 1971 1968 -3
Partials 337 337
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@afolson you know more about SEO than me - what's our preference on this? cc @lauraperezco |
@tayloramurphy same as the ELT page applies here, the main website has preference over subpages for SEO, so Jared's assesment is correct! I think ideally we should replace the current content in docs with a short introduction that takes you to the blog link for the full tutorial (and maybe reference some other blog-tutorials in the future to make this section in docs more complete while giving more authority to our website) |
Co-authored-by: Edgar R. M. <edgarrm358@gmail.com>
@lauraperezco happy to update with your suggestions 👍 From the Slack thread there was an aim to make the docs the place where users can find all this type of information. Linking out to blogs still achieves this |
Hey @jared-rimmer, no it's not necessary to update the page to include less. It can stay as you suggested, everything in once place. But FWIW we're aware that we need to figure out a guide for what goes where, that's still WIP ;) |
Co-authored-by: Edgar R. M. <edgarrm358@gmail.com>
Co-authored-by: Edgar R. M. <edgarrm358@gmail.com>
Co-authored-by: Edgar R. M. <edgarrm358@gmail.com>
Co-authored-by: Edgar R. M. <edgarrm358@gmail.com>
Co-authored-by: Edgar R. M. <edgarrm358@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all changes adressed!
PR creator addressed all changes.
I have ported over and merged content from:
https://meltano.com/blog/how-to-build-a-custom-extractor-with-meltano/
with the existing custom extractor tutorial in an attempt to making it a one stop shop for people wanting to get started with a creating a custom extractor.
Open questions