Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use random UUID as default project_id #6745

Merged
merged 1 commit into from Sep 13, 2022
Merged

Conversation

WillDaSilva
Copy link
Member

Closes #6733

@netlify
Copy link

netlify bot commented Sep 13, 2022

Deploy Preview for meltano canceled.

Name Link
🔨 Latest commit c97e0d1
🔍 Latest deploy log https://app.netlify.com/sites/meltano/deploys/6320b0fd10f00e000885365a

@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Merging #6745 (c97e0d1) into main (b56af55) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #6745   +/-   ##
=======================================
  Coverage   88.56%   88.56%           
=======================================
  Files         280      280           
  Lines       20226    20226           
  Branches     2002     2002           
=======================================
  Hits        17914    17914           
  Misses       1976     1976           
  Partials      336      336           
Impacted Files Coverage Δ
src/meltano/core/project_init_service.py 96.29% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@WillDaSilva WillDaSilva marked this pull request as ready for review September 13, 2022 17:48
Copy link
Contributor

@pandemicsyn pandemicsyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! but definitely hold for a +1 from @tayloramurphy on this one 😁

Copy link
Collaborator

@tayloramurphy tayloramurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@WillDaSilva WillDaSilva merged commit fa573a4 into main Sep 13, 2022
@WillDaSilva WillDaSilva deleted the no-name-in-project-id branch September 13, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

revert: project-name in project_id
4 participants