New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Correct migration path for state table #6795
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meltano canceled.
|
cjohnhanson
changed the title
Correct migration path for state table
fix: Correct migration path for state table
Sep 26, 2022
* Migrations test - maybe * Use installed target-sqlite
Codecov Report
@@ Coverage Diff @@
## main #6795 +/- ##
==========================================
- Coverage 88.68% 88.67% -0.01%
==========================================
Files 283 283
Lines 20471 20471
Branches 2024 2024
==========================================
- Hits 18154 18152 -2
- Misses 1978 1979 +1
- Partials 339 340 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
pandemicsyn
reviewed
Sep 26, 2022
src/meltano/migrations/versions/6828cc5b1a4f_create_dedicated_state_table.py
Show resolved
Hide resolved
pandemicsyn
approved these changes
Sep 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects the migrations for the new dedicated state table.
Closes #6790