Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct migration path for state table #6795

Merged
merged 10 commits into from Sep 27, 2022
Merged

Conversation

cjohnhanson
Copy link
Contributor

This corrects the migrations for the new dedicated state table.

Closes #6790

@netlify
Copy link

netlify bot commented Sep 26, 2022

Deploy Preview for meltano canceled.

Name Link
🔨 Latest commit 0db4473
🔍 Latest deploy log https://app.netlify.com/sites/meltano/deploys/63321a13c6641f0008567b11

@cjohnhanson cjohnhanson changed the title Correct migration path for state table fix: Correct migration path for state table Sep 26, 2022
@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Merging #6795 (0db4473) into main (3c51298) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #6795      +/-   ##
==========================================
- Coverage   88.68%   88.67%   -0.01%     
==========================================
  Files         283      283              
  Lines       20471    20471              
  Branches     2024     2024              
==========================================
- Hits        18154    18152       -2     
- Misses       1978     1979       +1     
- Partials      339      340       +1     
Impacted Files Coverage Δ
src/meltano/core/job_state.py 93.93% <100.00%> (ø)
src/meltano/core/state_service.py 96.66% <100.00%> (ø)
src/meltano/core/state_store.py 85.48% <100.00%> (ø)
tests/meltano/core/test_state_store.py 100.00% <100.00%> (ø)
src/meltano/cli/state.py 88.59% <0.00%> (-1.35%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cjohnhanson cjohnhanson marked this pull request as ready for review September 26, 2022 20:57
Copy link
Contributor

@pandemicsyn pandemicsyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: state table migration fails
2 participants