New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remote state backends #6911
Conversation
✅ Deploy Preview for meltano ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no major concerns with what's here. Really glad to see this coming along nicely!
ec2f954
to
ae80ed4
Compare
From 2022-11-03 discussion:
|
72e730a
to
3202a77
Compare
Codecov Report
@@ Coverage Diff @@
## main #6911 +/- ##
==========================================
- Coverage 88.76% 88.70% -0.07%
==========================================
Files 284 292 +8
Lines 20573 21281 +708
Branches 2028 2104 +76
==========================================
+ Hits 18262 18877 +615
- Misses 1976 2051 +75
- Partials 335 353 +18
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some docs suggestions now that #6628 has been merged
Co-authored-by: Edgar R. M. <edgarrm358@gmail.com>
Co-authored-by: Edgar R. M. <edgarrm358@gmail.com>
Co-authored-by: Edgar R. M. <edgarrm358@gmail.com>
👋 - question about this. I'm currently blocked on upgrading meltano from version 2.1.0 due to using Ubuntu 18.04 with an old version of sqlite so I thought that setting a different state backend would allow me to not care about the sqlite version. It appears that setting the state backend uri to a file location doesn't stop meltano from running migrations on its sqlite database anyway. Is that expected? |
@pdebelak yes, that's unfortunately expected at this point. I wonder if now that Meltano supports secrets backends, Meltano should allow users to disable database migrations, or disable the backend db entirely. |
@edgarrmondragon, @pdebelak - We have a bit more to do before we can fully replace systemdb.
However, since logging is "write only" as of now, perhaps we could disable the backend, in theory at least. If so, we'd have to fail if config get/set is attempted against systemdb, and we'd skip consideration of systemdb when using the auto-store decision tree for getting/setting config values. It would probably take a lot of testing and debugging to get right, but in theory it may be possible... 🤔 |
@edgarrmondragon, @pdebelak - We have a bit more to do before we can fully replace systemdb.
However, since logging is "write only" as of now, perhaps we could disable the backend, in theory at least. If so, we'd have to fail if config get/set is performed against it, and we'd skip consideration of systemdb when using the auto-store decision tree for getting/setting config values. It would probably take a lot of testing and debugging to get right, but in theory it may be possible... 🤔 |
Related discussion:
Feature README:
closes: #5981