New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Handle case where setting metadata is None
#6938
Conversation
Before: ``` $ meltano config meltano set state_backend.uri file:///${MELTANO_ROOT_DIR}/.meltano/state Need help fixing this problem? Visit http://melta.no/ for troubleshooting steps, or to join our friendly Slack community. 'NoneType' object has no attribute 'is_redacted' ``` After: ``` $ meltano config meltano set state_backend.uri file:///${MELTANO_ROOT_DIR}/.meltano/state Meltano setting 'state_backend.uri' was set in `meltano.yml`: 'file:////.meltano/state' ``` Closes #6937
✅ Deploy Preview for meltano canceled.
|
@WillDaSilva is the actual problem here that when you do a config for a setting that doesn't exist it gives this error? Looks like this is coming up because EDK things can use the config block however they want technically, right? |
@tayloramurphy Yes. Whether or not we want to permit setting these settings is unknown to me, but we definitely shouldn't be erroring in this way. I asked in the PR description:
If we do want it to error cleanly, I can update this PR to do so. |
@WillDaSilva I'd say have it execute but give a warning that "this setting is not known to Meltano". |
There's a nice parallel between that approach and what we do when a setting that does not exist is retrieved, which is emit a warning and return |
None
None
Codecov Report
@@ Coverage Diff @@
## main #6938 +/- ##
==========================================
- Coverage 88.75% 88.73% -0.03%
==========================================
Files 284 284
Lines 20548 20542 -6
Branches 2028 2027 -1
==========================================
- Hits 18237 18227 -10
- Misses 1976 1979 +3
- Partials 335 336 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Before:
After:
Instead of setting the non-existent setting, would we rather it error cleanly?
Closes #6937